code review.

[mediawiki_dump_tools.git] / code_review_notes.txt

diff --git a/code_review_notes.txt b/code_review_notes.txt
new file mode 100644 (file)
index 0000000..77b7de9
--- /dev/null
+++ b/code_review_notes.txt
@@ -0,0 +1,9 @@
+Please add unit tests for the new count-only functionality.
+
+line 43 def matchmake:
+     This was making redundant calls to regex matching functions and so could be slower than necessary. I suggest changes that use the walrus operator to keep the same logical structure without the redundant calls. 
+
+
+line 212 def __init__:
+
+     Minor note: This constructor is taking a lot of arguments.  This is fine, but from a style + maintainability perspective it might make sense to create a new class for the regex matching configuration and pass a configuration object to this contructor instead.